Adopt renamed DBN dependency: DatabentoBinaryEncoding#13
Conversation
DBN.jl was renamed to DatabentoBinaryEncoding.jl to satisfy Julia
General Registry naming guidelines (Triage rejected the original DBN
submission on grounds of all-caps, <5 chars, and Damerau-Levenshtein
collisions with DSP/BDF/JDBC/etc.). UUID is unchanged.
DatabentoAPI.jl side of the rename:
- Project.toml: [deps], [sources], [compat] keys renamed from DBN to
DatabentoBinaryEncoding. [sources] path updated to point at the
renamed local folder.
- .github/workflows/CI.yml: clone target updated from DBN.jl to
DatabentoBinaryEncoding.jl, develop step updated.
- src/ and test/ and benchmark/: every `using DBN` now does
using DatabentoBinaryEncoding
import DatabentoBinaryEncoding as DBN
The alias means all existing `DBN.foo` references inside this package
stay unchanged — idiomatic Julia for verbose package names.
- src/DatabentoAPI.jl: top-level module docstring + the
`import DBN`/`using DBN: ...` lines updated to reference the new
package name; alias still binds the short `DBN` identifier so the
rest of the file is unchanged.
Local Manifest.toml has been regenerated (deleted; CI's Pkg.instantiate
will recreate). Local Julia 1.13 beta has a broken LibCURL that
prevents Pkg.instantiate, so this commit was not smoke-tested locally;
CI is the verification.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7824037af2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| include("bench_common.jl"); using .BenchCommon | ||
|
|
||
| using DBN | ||
| using DatabentoBinaryEncoding |
There was a problem hiding this comment.
When running the documented benchmark entry point (julia --project=benchmark benchmark/runbench.jl), these renamed imports are resolved against benchmark/Project.toml, but that environment still declares DBN = "90689371-c8cb-40d1-831f-18033db90f74" and a [sources] path for ../../DBN.jl rather than DatabentoBinaryEncoding. As a result the benchmark project has no root dependency named DatabentoBinaryEncoding, so the first included benchmark that executes this import will fail with the package not found unless the user manually edits/devs the benchmark environment too.
Useful? React with 👍 / 👎.
DatabentoBinaryEncoding v0.1.0 is now in General. The local-path [sources] entry and the CI dev-clone steps were workarounds for the unregistered dep; both go away now that Pkg can resolve the dep through the registry like any normal dependency. - Project.toml: remove [sources] block. - .github/workflows/CI.yml: remove "Clone DatabentoBinaryEncoding.jl" and "Dev DatabentoBinaryEncoding.jl + instantiate" steps. The julia-actions/julia-buildpkg step handles instantiate from the registry. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 participant
Summary
DBN.jl was renamed to DatabentoBinaryEncoding.jl (rename PR) after Julia Triage rejected the General Registry submission of
DBNagainst naming guidelines. UUID unchanged.This PR adopts the new dep name on the DatabentoAPI side:
Project.toml:[deps],[sources],[compat]keys renamed fromDBNtoDatabentoBinaryEncoding.[sources]path updated to the renamed local folder..github/workflows/CI.yml: clone target updated.src/+test/+benchmark/: everyusing DBNnow doesThe alias keeps every internal
DBN.fooreference unchanged — idiomatic Julia for verbose package names (cf.LinearAlgebra as LA).src/DatabentoAPI.jl: top-level docstring +import DBN/using DBN: ...lines updated.Dependency
Blocked on tbeason/DatabentoBinaryEncoding.jl#19 merging. CI here will be red until that lands (the renamed clone target doesn't exist on origin/main yet).
Test plan
Pkg.instantiate, so this commit was not smoke-tested locallyFollow-ups
🤖 Generated with Claude Code